search

geraldneo567 / pe

0 stars 0 forks source link

No input validation for owner #12

Open geraldneo567 opened 2 years ago

geraldneo567 commented 2 years ago

Command is edit o/LONG NAME

image.png

nus-se-script commented 2 years ago

Team's Response

photo_2022-04-18 22.51.36.jpeg

We feel that this is a deliberate sabotage on tester's part. We think that owner name will not be this long. Furthermore, it does not affect our GUI in any way.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Firstly, the GUI is affected because there may be users with smaller screens (i.e 10-inch laptops) who would not be able to enlarge the screen any more, and have part of the text cut off (as opposed to wrapping round, for example).

The longest person's legal name in the world is 747 characters (https://www.guinnessworldrecords.com/world-records/67285-longest-personal-name#:~:text=The%20longest%20personal%20name%20is,to%20Hubert%20Blaine%20Wolfeschlegelsteinhausenbergerdorff%20Sr.). Barring this extreme example, the owner's name was cut off in the screenshot I posted with an input of only about 70-80 characters, which is not unheard of in a person's name. In fact while it may be less common in Singapore, there are certain parts of the world where people's names may be a bit longer. Additionally this bug means this situation is not handled since the back part (e.g. last name) is cut off from the GUI. It is better to validate the user's input (since currently, what is saved into JSON is longer and different from what is actually displayed to the user in GUI - and what user sees after entering the long name does not tally with what he typed in).