search

geraldneo567 / pe

0 stars 0 forks source link

Appointment command does not check for timing #14

Open geraldneo567 opened 2 years ago

geraldneo567 commented 2 years ago

It was specified that appointment must be in the future, but I am able to enter an appointment on the same date (but an earlier timing) without an error message and the appointment is still green (should be red showing the appointment is missed). See screenshot (Com time vs appt time)

image.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Past time can be added as appointment

app 1 dt/16-04-2022 02:20 at/skfjkh jksdhf

Past time of today can be added as an appointment even if the time has passed.

Screenshot 2022-04-16 at 2.55.32 PM.png

[original: nus-cs2103-AY2122S2/pe-interim#854] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the review.

This feature is actually intended. We only restrict adding past dates, which means anytime today is still possible.

The reason for this is pets may have last-minute appointments on the day itself and the pet daycare owners might only key it in the system later in the day.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It only specifies the DATE cannot be a past date. The UG did not say anything about the time, or if the date is the same and therefore does not cover this actual scenario. Date =/= time. Therefore this feature is not handled correctly (especially since if it is in the past, it is clearly a "Missed" appointment and should be highlighted red).

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: I believe this is more a feature flaw than a bug because the app still "works" per se - in the sense that the functionality is there and the appointment does appear, just that it is wrongfully highlighted green.