search

geraldneo567 / pe

0 stars 0 forks source link

No input validation for address #6

Open geraldneo567 opened 2 years ago

geraldneo567 commented 2 years ago

Able to enter abritraily long address. image.png

nus-se-script commented 2 years ago

Team's Response

photo_2022-04-18 22.51.36.jpeg

We feel that this is a deliberate sabotage on tester's part. Singapore's address will typically never be this long. Furthermore, it does not affect our GUI in any way.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Firstly, the GUI is affected because there may be users with smaller screens (i.e 10-inch laptops) who would not be able to enlarge the screen any more, and have part of the text cut off (as opposed to wrapping round, for example).

It is not unheard of for locations/addresses to be slightly longer. In this situation, especially if the user has a smaller screen, it would lead a back portion of the appointment location being cut off. Unlike the Breed which I now agree upon deliberation can never be so long, I believe for this case the input has to be validated to prevent the cosmetic issue of GUI cutting off the text.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]