search

geraldneo567 / pe

0 stars 0 forks source link

No input validation for diet #8

Open geraldneo567 opened 2 years ago

geraldneo567 commented 2 years ago

There should be an upper limit to how long the "diet' should be. Command used is add and pass diet argument that is very long.

image.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incomplete display of diet

diet 1 d/aksgfhskjd wef wef af af sderg egreg afsjkhv as f sfds gdf ger ger g rt g e fsd asdksutfgdsjkdgkasjmdhkajshdkjashfkdsjgfkdjsgkjdshkfjhsdkjfhkjdshfkjwehkfjhwekhdqoiwhdoiqhdajshdkjashdkjashdkjs Screenshot 2022-04-16 at 2.51.43 PM.png

It is medium because it is more than a cosmetic problem, diet information about a pet is very important as it might risk the life of the pet. So it is very necessary for the users to know the full requirement.

[original: nus-cs2103-AY2122S2/pe-interim#851] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This input is clearly deliberate sabotage as this long input did not crash the application, corrupt the date or make it unusable.

image.png

Additionally, if the user were to try expanding/viewing this in full-screen, they should be able to view the full diet description.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is not a deliberate sabotage. The diet field was cut off in the given example with only roughly 50 characters. What if the description was longer and contained important information? For example, "Only eats dry food, allergic to XXX, YYY, ZZZ, eats every 4 hours, has to take medicine after", etc etc. If the back part is cut off then this could be very harmful to the pet. The team mentioned "Additionally, if the user were to try expanding/viewing this in full-screen, they should be able to view the full diet description.", but does this not depend on the screen size? What if the daycare centre uses a small screen like a 10 inch notebook/tablet? In this situation this is definitely a bug since the intended use of the program is to fully display the diet information but this no longer occurs and the GUI cuts off a portion of the text.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This is more than just a cosmetic issue, it is of vital importance, quoting the other bug report, "diet information about a pet is very important as it might risk the life of the pet. So it is very necessary for the users to know the full requirement.". Additionally the team seems to downgrade almost every problem's severity so I do not think it is very fair for them to do that on their part, especially when this is clearly an oversight that affects the usefulness/functionality of the app.