search

gerane / VSCode-FlatlandMonokaiTheme

VSCode Flatland Monokai Theme
16 stars 5 forks source link

Too many underlines #4

Open W4RH4WK opened 8 years ago

W4RH4WK commented 8 years ago

A lot of tokens have underlines and I think this is not supposed to be. Would be great if you could update the theme anytime soon.

Dev-tools gave me this reference: .monaco-editor.vs-dark.gerane-Theme-FlatlandMonokai-themes-Flatland_Monokai-tmTheme .token.entity.name.class

image

ArturKwiatkowski commented 8 years ago

I agree since one of the recent updates in VSC this theme has lost it's previous look'n'feel. If you open any typescript file and make a method and then use the this keyword - it also changed. If you could do anything with this it would be super awesome cause there is no better theme in the market for this editor.

gerane commented 7 years ago

Sorry for late response. I think this was caused by a change in scoping. Would it be better if there was no underlining for the class name scope?

Are there any other areas that also need improvement?

W4RH4WK commented 7 years ago

@gerane Thank you for the response. I am currently not using this theme, therefore I don't have any additional changes in mind. I'd ditch the underlining in general. looking at other people's themes, most of them do not use underline as regular highlighting.

gerane commented 7 years ago

@W4RH4WK Understood. I will have to give this some thought. This theme was ported from the textmate theme and it uses underlines in the same way as the default monokai theme that is built into code.

rediffusion commented 4 years ago

@W4RH4WK

I agree with deleting the underlines!