[Feature Request] Asciidoc[tor] Syntax Highlighting Missing

[sanguine8082]

The first picture is a shot of my document using the Monokai Color Scheme. The second is a shot of the same document using the Brogrammer Color Scheme.

[gerane]

@sanguine8082 which asciidoc extension are you using? The syntax is going to look different based on the language extension. I added some better markdown support but the asciidoc parts looked very different between different languages I tried.

[sanguine8082]

Thank you for taking the time to respond to this inquiry!

I am using this extension: https://github.com/JustusAdam/language-asciidoc

I prefer using asciidoc over markdown :P

I use it for taking notes at work. I have an aggregate .adoc file, where I link in the adoc files for each day. Can you do something similar in markdown?

I never thought that it could be a problem of the language extension. I assumed it was related to the themes because the default Monokai theme supports 80% of the highlighting, but other themes such as Ayu or Brogrammer support 50% or less.

Thanks for taking the time to look into this! Please let me know if you need any more information

On Tue, Jan 24, 2017 at 5:01 PM Brandon Padgett notifications@github.com wrote:

@sanguine8082 https://github.com/sanguine8082 which asciidoc extension are you using? The syntax is going to look different based on the language extension. I added some better markdown support but the asciidoc parts looked very different between different languages I tried.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gerane/VSCodeThemes/issues/26#issuecomment-274967377, or mute the thread https://github.com/notifications/unsubscribe-auth/AIZL6s4KXBTlpBnyzlLFlkhPdbPxgIXUks5rVoK0gaJpZM4LbUaO .

[gerane]

I am not very familiar with asciidoc, but looking at that language and the syntax it looks like the few things with colored just lined up to be white. Is there any examples of the things you want colored and which colors? I can try to add the syntax to the theme.

[gerane]

Have you tried this extension?

https://marketplace.visualstudio.com/items?itemName=joaompinto.asciidoctor-vscode

It seems to have better support for the language. It has at least some syntax coloring out of the box. I am looking at improving it, but was wondering if there was a reason you were using that one instead.

[sanguine8082]

Thank you for doing some research. I moved to Visual Studio Code from Atom. Atom had a very sophisticated language highlighting for the language (via a plugin). Well at least I would call it sophisticated.

Snippet from Atom: [image: pasted1] Snippet from VSCode (using default dark theme): [image: pasted2]

Just some small stuff like that. In other themes in VSCode, the presence of that icon:arrow-right[] in the line, highlights the entire line with syntax coloring. I know I'm just ignorant of the inner workings of the language extension/theme coloring interactions. So, I'm baffled by the inconsistently of the highlighting throughout different themes.

On Wed, Jan 25, 2017 at 4:50 PM Brandon Padgett notifications@github.com wrote:

Have you tried this extension?

https://marketplace.visualstudio.com/items?itemName=joaompinto.asciidoctor-vscode

It seems to have better support for the language. It has at least some syntax coloring out of the box. I am looking at improving it, but was wondering if there was a reason you were using that one instead.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gerane/VSCodeThemes/issues/26#issuecomment-275257927, or mute the thread https://github.com/notifications/unsubscribe-auth/AIZL6hRGgy4CH4HwEUNcCAL-4q3K9VgTks5rV9GYgaJpZM4LbUaO .

[sanguine8082]

The plugin you linked to appears to have some problems recognizing '#'s. Two hashes indicates italicized text, but it looks like it gets stuck for a single one, and searches the rest of the file for its matching end point! I had that same problem with the language extension for Sublime Text

On Thu, Jan 26, 2017 at 9:51 AM Aaron Pfalzgraf apfalzgraf8082@gmail.com wrote:

Thank you for doing some research. I moved to Visual Studio Code from Atom. Atom had a very sophisticated language highlighting for the language (via a plugin). Well at least I would call it sophisticated.

Snippet from Atom: [image: pasted1] Snippet from VSCode (using default dark theme): [image: pasted2]

Just some small stuff like that. In other themes in VSCode, the presence of that icon:arrow-right[] in the line, highlights the entire line with syntax coloring. I know I'm just ignorant of the inner workings of the language extension/theme coloring interactions. So, I'm baffled by the inconsistently of the highlighting throughout different themes.

On Wed, Jan 25, 2017 at 4:50 PM Brandon Padgett notifications@github.com wrote:

Have you tried this extension?

https://marketplace.visualstudio.com/items?itemName=joaompinto.asciidoctor-vscode

It seems to have better support for the language. It has at least some syntax coloring out of the box. I am looking at improving it, but was wondering if there was a reason you were using that one instead.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gerane/VSCodeThemes/issues/26#issuecomment-275257927, or mute the thread https://github.com/notifications/unsubscribe-auth/AIZL6hRGgy4CH4HwEUNcCAL-4q3K9VgTks5rV9GYgaJpZM4LbUaO .

[gerane]

They were likely using the same language. They both use textmate language files.

I will see what I can figure out for the other theme