gerane / VSCodeThemes

Themes for Visual Studio Code

200 stars 77 forks source link

Github: Highlighting makes text dissapear #27

Closed fpigeonjr closed 7 years ago

fpigeonjr commented 7 years ago

Disappearing when Highlighting

When I select text like in the screenshot the selected text disappears. Thanks for adding all these great Color themes to VSCode.

gerane commented 7 years ago

Which theme is this?

fpigeonjr commented 7 years ago

This is the Github theme. Thanks for taking a look.

gerane commented 7 years ago

I will try to take a look at it this weekend.

fpigeonjr commented 7 years ago

thanks @gerane. I appreciate you helping the vscode community with all these great themes.

gerane commented 7 years ago

@fpigeon I tested changing the selection color to a lighter shade of #72d3d1

Do you think this works better? The comments are a little hard to see, but given they are comments I wasn't sure if they really needed to be changed. Here is a quick example.

capture

What sort of highlighting would you think would work best? I was hesitant to try a lighter gray tinted color since that would likely be even harder to avoid conflicts.

fpigeonjr commented 7 years ago

@gerane This highlight color looks great and I think is consistent with the theme, Agree that grey would not work as well. Looking forward to the update as this is my fav light theme.

MarcelloTheArcane commented 4 years ago

This happens with the Earthsong theme (#54) - I've changed my colour to #995c40.

What do you think?

Before: before After: after