search

gerane / VSCodeThemes

Themes for Visual Studio Code
200 stars 77 forks source link

Highlight using wrong colors for Solarized Light Theme #41

Closed felipecrp closed 7 years ago

felipecrp commented 7 years ago

This is a sample code, in which the cursor is on "abc" string.

In vscode 1.7.2, it use the right colors:

old

But in vscode 1.11.2, it use the same (or near same) color of selection:

new

gerane commented 7 years ago

I'm not quite sure what they changed. I did see one issue with this theme that I will be fixing, but it wasn't related to this. I will have to look into this a bit more. Was 1.7.2 the latest version you had tried before 1.11.2? I am wondering at what point this started happening.

felipecrp commented 7 years ago

Yes, i updated from 1.7.2 to 1.11.1, and after 1.11.2. The wrong highlight happens in 1.11.1 and 1.11.2.

felipecrp commented 7 years ago

Read the change logs, it may be the update from version 1.9 or 1.11

https://code.visualstudio.com/updates/v1_9 - they changed something in themes to be more accurate with textmate

https://code.visualstudio.com/updates/v1_11 - they launched new features for themes

felipecrp commented 7 years ago

Can you tell what is the "theme tag" for highlight repeated ocurrences and selection?

gerane commented 7 years ago

Sorry for the delay. I've been sick and daughters been sick. Even missed a conference over the weekend. I'll try to check into this sometime today. It looks like part of it is working as intended now, but something is still clashing. The foreground color should be lighter and the background color is actually showing more the way it should be. I'll try to see of I can find a good mix to make everything look proper.

gerane commented 7 years ago

Ok. I made a change that should make this a lot better and fixed an issue with it being defined as a dark theme. I think there should eventually be some better ways to customize these, but right now it doesn't look like it works for tmtheme. This may be something that only works in their newer json format. I am waiting until that is more finalized before I start moving themes to it.