search

gerardbm / vim-atomic

Atomic color scheme for Vim, Neovim and Gvim
https://github.com/gerardbm/atomic
MIT License
16 stars 1 forks source link

white column in dark mode #4

Closed Karmenzind closed 4 years ago

Karmenzind commented 4 years ago

With set cursorcolumn

As you can see, the column is too much white...

image

It's softer in solarized.

image

gerardbm commented 4 years ago

The color of the column is very soft, the same of the cursorline, as in solarized. This is the code: https://github.com/gerardbm/vim-atomic/blob/master/colors/atomic.vim#L428-L432 (using s:base2).

Screenshot using Vim8: screenshot-using-vim

However, if the terminal has gui_running or termguicolors, it will show a blue, cyan, orange or red dark color (s:base5, created for this case), depending on the scheme you use.

Screenshot using Gvim (using the :AtomicDarkBlueSoft): screenshot-using-gvim

What I could do is to remove this conditional (L428), remove the colors s:base5 and simply use the colors of s:base2 for all (Vim, Gvim, Neovim, and so on). I could do the same with the other components behaving like that, for example the color of the selection.

I will change it. But I would like to know why is it showing a white line on your setup. Curiosity.

Karmenzind commented 4 years ago

Thank you. Maybe you should check hl-Cursorcolumn. It's different with hl-Colorcolumn.

Here it is: image

gerardbm commented 4 years ago

Oh, yes. You're right. CursorColumn was missing. Thanks! Fixed and closed.

Karmenzind commented 4 years ago

Thanks a lot.