Closed Konafets closed 6 years ago
I propose the renaming of the following methods from PlanSubscription:
PlanSubscription
active()
isActive()
onTrial()
isOnTrial()
canceled()
isCanceled()
ended()
hasEnded()
This has two reasons:
is
has
scopeCanceled()
$canceledSubscriptions = Subscription::canceled()->get();
I can not do that currently because of the canceled() method. This will be called instead of the scope.
This is a BC break.
I agree, can be added for v2.
Thanks!
I propose the renaming of the following methods from
PlanSubscription
:active()
toisActive()
onTrial()
toisOnTrial()
canceled()
toisCanceled()
ended()
tohasEnded()
This has two reasons:
is
orhas
scopeCanceled()
which will be used like this:I can not do that currently because of the
canceled()
method. This will be called instead of the scope.This is a BC break.