gerardojbaez / laraplans

SaaS style recurring plans for Laravel.
http://laraplans.readthedocs.io
MIT License
180 stars 80 forks source link

BC: Rename boolean methods of PlanSubscription #11

Closed Konafets closed 6 years ago

Konafets commented 7 years ago

I propose the renaming of the following methods from PlanSubscription:

This has two reasons:

  1. It is a convention to have these kind of methods prefixed with is or has
  2. The current naming interferres with the scope feature. I want to create a scope scopeCanceled() which will be used like this:
$canceledSubscriptions = Subscription::canceled()->get();

I can not do that currently because of the canceled() method. This will be called instead of the scope.

This is a BC break.

gerardojbaez commented 7 years ago

I agree, can be added for v2.

Thanks!