in laravel 5.5 not working, can you update plz

[pay2all]

in laravel 5.5 not working, can you update plz

[oanhnn]

+1

[siarheipashkevich]

@pay2all, @oanhnn could we please confirm that this problem has been fixed?

[gerardojbaez]

What errors are you guys experiencing? Is it the same reported in #26?

I'm using Laraplans (dev-master) on a project using Laravel 5.5, all tests are passing; maybe the fix is already in place (7f8c23b95788da9a09a0cbe17bea3de5da83a63e), but has not been released yet.

[sanjaylive]

[gerardojbaez]

Thanks, @sanjaylive. There's already a commit that solves this error... I will create a release soon. If you are still under development, you can try dev-master to try things out.

[siarheipashkevich]

I've the same issue in laravel 5.5.

[sanjaylive]

check update, already solved

On Fri, Jan 26, 2018 at 8:38 PM, Siarhei Pashkevich < notifications@github.com> wrote:

I've the same issue in laravel 5.5.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gerardojbaez/laraplans/issues/24#issuecomment-360809592, or mute the thread https://github.com/notifications/unsubscribe-auth/AdTxi0M51yz-Jc53-WGsswUQXh-PaRjXks5tOep0gaJpZM4Q4Ozl .

[siarheipashkevich]

I've switched to dev-master and problem was fixed. But I think we should create a new release.

[josteph]

Please see to this issue (if you're not using dev-master) for the fix. #30

[oanhnn]

You can try my package oanhnn/laravel-pricing-plans

[josteph]

@oanhnn You could have forked this package from @gerardojbaez rather than claiming it as your own.

[oanhnn]

@josteph Yes, it is a fork, but the license of @gerardojbaez 's package is MIT and i did refactor it 😄

[gerardojbaez]

@oanhnn, Having the MIT license doesn't mean you can claim it as yours; it clearly says that you have to preserve the Copyright along with the provided License. Please make the necessary adjustments to your repository. Refactoring someone else code doesn't make it yours.

[oanhnn]

@gerardojbaez I know my project the development on your project and your solution. Thank you very much about it.. But actually I have developed it on my idea and solution from mid-2017. You can now see it is different very much with your project. However, I have linked to your project as the source of the project and added your name to the license in commit afe05cee6fd1c0b1e9f5fbfe672f48dd2cbb4967

[gerardojbaez]

@oanhnn, Thanks for the adjustments. Your project is base on Laraplans, it doesn't matter if you have refactored it or built on top of it, the original Copyright must be included (and you already did). More information here.

This is how I would do it (it is more explicit):

Original work Copyright © 2016 Gerardo Baez <g@gerardobaez.com>
Modified work Copyright © 2017-2018 Oanh Nguyen <oanhnn.bk@gmail.com> 

[gerardojbaez]

The release is out! v2.2.0