Add kitty terminal strategy

gerardroche / sublime-phpunit

PHPUnit Sublime Text integration.

https://www.gerardroche.com

GNU General Public License v3.0

74 stars 11 forks source link

Add kitty terminal strategy #104

Closed amirHossein5 closed 1 year ago

amirHossein5 commented 1 year ago

Add kitty strategy option,

Screenshot from 2023-04-05 21-35-01

gerardroche commented 1 year ago

I think the reason the phpunit.options setting can't be used and a strategy is needed is because kitty --hold has to be first in the cmd string. The phpunit.options are appended after the phpunit script.

I'm wondering if it might be better to add something like a phpunit.exec_cmd option. Then you would be able to just set phpunit.exec_cmd to ['kitty', '--hold'].

amirHossein5 commented 1 year ago

Yeah, that's more flexible, I'll send another PR.

gerardroche commented 1 year ago

@amirHossein5 I went ahead and added the Kitty strategy. I should have done that in the first place. Let me know if I implemented correctly.

amirHossein5 commented 1 year ago

Yeah, but

Is there any way to automatically panel be invisible on kitty strategy? I've added show_panel_on_build to my settings to disable that.
colors(for artisan) are missing(shows correct colors for phpunit command).