gerardsimons / pbr-visualizer

Physically-based rendering visualization tool
MIT License
0 stars 1 forks source link

pbr-visualizer embree compiling error #3

Open ttsesm opened 4 years ago

ttsesm commented 4 years ago

Hi @gerardsimons I am trying to compile the pbr-visualizer and I am getting the following error:

../pbr-visualizer/common/simd/sseb.h:108:29: error: could not convert ‘_mm_shuffle_epi32(a, ((((i3 << 6) | (i2 << 4)) | (i1 << 2)) | i0))’ from ‘__m128i’ {aka ‘__vector(2) long long int’} to ‘const embree::sseb’
  108 |     return _mm_shuffle_epi32(a, _MM_SHUFFLE(i3, i2, i1, i0));
      |            ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                             |
      |                             __m128i {aka __vector(2) long long int}

Do you know how I could solve it?

I am using Embree 3.9 and GCC 9.3.0 and I am on a linux system.

Thanks.

gerardsimons commented 4 years ago

Hi there! So sorry about the delay. I haven't looked at this code for a while. Are you still facing this issue? I can try and run it again for you. What C++ version are you using? Though the most likely candidate seeing how old this code is is that it's not compatible with the newer version of EMBREE.

ttsesm commented 4 years ago

No worries, as I've mentioned I am using GCC 9.3.0 so it should support C++14 which is a requirement. Yes, I think the issue has to do with the new EMBREE lib version. I tried to make some changes in the common folder, but I didn't manage to make it work at the end. I am not sure how easy would be to update the code for the new EMBREE lib version.

gerardsimons commented 4 years ago

I think it would be easier to try older versions of EMBREE:

https://github.com/embree/embree/releases

It's a bit silly that I did not list the exact version of EMBREE we rely on. @TobiasRp Do you remember which exact one we used? Otherwise go back to around the time that this was last updated... Sorry that I cannot help more at this time. Will try to find some time in the future to try and upgrade.

ttsesm commented 4 years ago

@gerardsimons thanks for the feedback. I will try to check with an older version of EMBREE once I find some time.