search

gerardstevan / pe

0 stars 0 forks source link

The subject is too limited, whereas there are many other subject besides the one allowed #5

Open gerardstevan opened 1 year ago

gerardstevan commented 1 year ago

image.png

nus-se-bot commented 1 year ago

Team's Response

It is our design choice, for this iteration we believe that these subjects are enough

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: So, I think they are trying to argue not in scope.

image.png

I have seen their code and I believe they could have easily accommodate other subject quite easily such as coding classes which has quite a number of students to my knowledge (or another alternative might be just don't restrict the subject)

image.png They only need to add additional if statement in the ParseUtil class which I don't think will take much time, and some addition to error message and documentation