search

gerasimou / EvoChecker

EvoChecker
GNU General Public License v2.0
4 stars 3 forks source link

Initial Port is not configurable #11

Closed maormann closed 4 months ago

maormann commented 4 months ago

This line will always ensure that port 8888 is selected as INIT_PORT.

https://github.com/gerasimou/EvoChecker/blob/c2e8c5265d48a49bedb8485fa4e9192b82802f3d/src/main/java/evochecker/auxiliary/ConfigurationChecker.java#L106

Therefore, it is currently not possible to configure the initial port.

gerasimou commented 4 months ago

@maormann I believe this has been fixed in commit cda1a6f

see https://github.com/gerasimou/EvoChecker/blob/master/src/main/java/evochecker/auxiliary/ConfigurationChecker.java#L90-L95

You may be using an older version?

maormann commented 4 months ago

Hey @gerasimou, that is correct. At the time I opened the ticket, the master branch was still at c2e8c52

Here is the code of my pipeline that led to this version:

git clone https://github.com/gerasimou/EvoChecker.git evochecker || true && cd evochecker && mvn install

Seems commit cda1a6f was in the branch newEC.

However. I have tested the latest version and the initial port is now set correctly.

So I see this Issue closed.

gerasimou commented 4 months ago

Thanks for the feedback @maormann.

We are currently working on extending EvoChecker, so if you have any further points, please send them our way.