Profiler - Githubissues

gerazo / pipert

Real-Time meets High-Delay: A hybrid scheduling and dataflow framework for DSP applications

GNU General Public License v3.0

6 stars 5 forks source link

Profiler #35

Closed gerazo closed 3 years ago

gerazo commented 3 years ago

So I have implemented our measurement module concept outlined in https://github.com/gerazo/pipert/issues/6

What is in it:

The full Profiler and Logging API towards the user
Aggregation logic
Serialization to network byte order
Dumb implementation of a file logger (writes in network byte order still)
Built-in events logged
Custom user log event types
Thread collecting and sending logs in the background
Documentation
Tests for all internal stuff

What is missing:

Integration tests with the Scheduler from ProfilerTest.cpp
Implementation of the whole UDP communication of sending logs
...and a big review

Hossam-Abdin commented 3 years ago

Questions:

why the naming is temporality? would not that make an issue while logging?
I can not see any changing in the kUntaggedValue, so how can the threads have different values?

Comments:

I can not see where the conversion happening in the endianness at all.

gerazo commented 3 years ago

@Hossam-Abdin Check out https://github.com/gerazo/pipert/blob/profiler/src/Endianness.h for endianness. It is called from the serializing functions in the introduced monitoring classes. Also check out thread_local variables in https://github.com/gerazo/pipert/blob/profiler/src/ThreadId.h These are also always static. So there is one single instance of them between every objects, but there is a separate one for every thread. This is how thread are identified. Basically, the thread governing Scheduler tags them before every job execution and this value is just used by the monitoring.

Hossam-Abdin commented 3 years ago

Thank you, these were my concerns, but otherwise, the work looks super great