gerby-project / gerby-website

Tag-based webview of LaTeX documents
MIT License
28 stars 22 forks source link

Daniel's issues #105

Closed aisejohan closed 5 years ago

aisejohan commented 6 years ago

The following suggestions are made by a user, let's call them Daniel, looking at the site on a phone.

Personally, I like the up button suggestion. I feel the analogues thing for the first lemma in a section would be less useful (and indeed it wasn't suggested by the user) because you can just go up the breadcrumb.

pbelmans commented 6 years ago
aisejohan commented 6 years ago

About the last point: when you click on the section in the breadcrumb you go to the beginning of the section.

pbelmans commented 6 years ago

Sorry, I didn't read things properly. Phrased like that it makes sense (even more so for Kerodon than the Stacks project I think). I'll have a go at implementing this.

pbelmans commented 6 years ago

One silly thing that I can't fix right now is the offset for the link caused by the always visible header. That would require fiddling with plasTeX output and styling, which I don't want to do this close to the release (not that it would be hard, but there might be ramifications).

pbelmans commented 6 years ago

And in any case, we need to improve the handling of the header offset at some point, to deal with variable size headers.

pbelmans commented 6 years ago

Can you update the server? I've implemented this now, then you can check whether you like it.

I discovered that we more generally deal with the sticky sidebar in a wrong way (but it only happens in sidecases). We need to think about that more carefully at some point.

aisejohan commented 6 years ago

OK, I tried this, but I think it is currently not an improvement. I'm worried about making too many changes close to the deadline, so I suggest we (for now) revert this and we get back to it later.

More detail: the "go to section button" IMHO shouldn't be there and it looks bad. Daniel's idea was to only change the thing in the sense that for the last lemma in the section, in stead of not having the next button, you have an up button in the location where you would have had the next button if it weren't the last lemma.

pbelmans commented 6 years ago

But that wouldn't make much sense, you always want to be able to jump into the surrounding context, not just if you happened to be at the last lemma.

I've put the extra output in comments.

aisejohan commented 6 years ago

Ok, well, if it doesn't make sense, then we don't do it.

One possible future fix: put a small up button in between previous and next?

pbelmans commented 6 years ago

Always, or only for things which are at the end of a section? If anything, it should be always, and then I think the solution I first implemented is better than putting it in the middle.

aisejohan commented 6 years ago

Agree to disagree?

pbelmans commented 6 years ago

Sure. We should revisit this in a few weeks, when the dust on the new website has settled.