gerby-project / gerby-website

Tag-based webview of LaTeX documents
MIT License
28 stars 22 forks source link

Extend breadcrumb links over the full tag title #116

Closed iblech closed 6 years ago

iblech commented 6 years ago

Currently, the links in the breadcrumbs extend only over the part/chapter/section number, not on the full tag title. I find it difficult to click on these short links, especially on mobile. This pull request changes the design so that the links extend over the full title. Beware that I haven't tested this change!

On an unrelated note, I noticed that the code doesn't include closing </li> tags. Should we add them for good measure?

pbelmans commented 6 years ago

At least for now it is intentional to only have the number as a link, not the the whole text: when the breadcrumb is displayed on multiple lines I want to avoid a clash of clickable areas, at the cost of making the clickable area smaler. And this way things are always the same, as in the main text only the number / tag is clickable.

So for now I'll leave it as it is, but I'll take it into consideration.