gerby-project / gerby-website

Tag-based webview of LaTeX documents
MIT License
28 stars 22 forks source link

recent-comments.xml #98

Closed aisejohan closed 6 years ago

aisejohan commented 6 years ago

The recent-comments.xml page does not yet work correctly. What seems to be missing is in the gerby/views/comments.py one needs to add more information to the call of render_templace

aisejohan commented 6 years ago

Are you sure this fixes it? I think there needs to be a change in the file gerby/views/comments.py on line 20??? I'm going to reopen this until I can test the solution in about an hour or so.

pbelmans commented 6 years ago

Yes: the problem was that

Locally it works fine, and I don't see any reason why it wouldn't on the server.

aisejohan commented 6 years ago

OK, sorry, yes this is fine now. My browser doesn't see the xml page as an xml page. So now I am testing it in my rss reader...

aisejohan commented 6 years ago

My feed reader complains about LibXML error 63 at line 124 (column 7): CData section not finished <p>Yes, this seesm true!</p>]] ></content:encode

pbelmans commented 6 years ago

That was a weird typo.

aisejohan commented 6 years ago

OK, will test...

pbelmans commented 6 years ago

I'm validating it through W3C now, fixing some issues.

aisejohan commented 6 years ago

While you're at it: my rss reader often complains about weird characters in the names of people for the current rss feed... Especially german characters it seems.... For example in the https://stacks.math.columbia.edu/tag/03T4#comment-3293 the double s causes trouble. It could be my feeed reader of course...

aisejohan commented 6 years ago

I'm using tt-rss

pbelmans commented 6 years ago

Everything should be UTF-8 the way we serve it. In which way does it cause trouble?

aisejohan commented 6 years ago

Here is the error: LibXML error 26 at line 97 (column 49): Entity 'szlig' not defined I checked and this refers to the double s. But again this is for the current version not the new one.

pbelmans commented 6 years ago

Ah, that might be fixed now, because the new code will output UTF-8 there, no HTML encodings are used where they shouldn't.

aisejohan commented 6 years ago

Opening this again until it works on server. It may not be because of the code but still...

aisejohan commented 6 years ago

OK, and now it works...

pbelmans commented 6 years ago

The files on the server were outdated. I'll pingpong this again to a closed state.