Closed gordonwoodhull closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
hexapipes | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 26, 2023 8:40pm |
Okay, I think I have addressed everything you suggested.
I also made TransformedPolygonTile
simpler / more consistent by standardizing on tile coordinates for its inputs (whereas the RegularPolygonTile
expects polygon coordinates).
The transformation framework should be all ready for P3 and whatever else. 🪄
Let me know if it needs any more changes. I have maintained open source and I know it's important to get everything right.
Thanks for the changes! I have more nitpicks... But I'm fine with merging this into a branch and finishing it myself. I mean things like:
So if you'd rather start thinking about P3 and not deal with this then just say so)).
The mark gestures feel a little bit off due to the transformation. I have to remember to go with the false perspective and along the pipe/mark directions, instead of from center to center.
This is workable, but if I forget then nothing happens or the gesture can even cause the opposite effect, drawing a wall when I meant to draw a connection.
I owe it to myself to take a couple days off the computer (although I’m cheating this afternoon and playing cube wrap on my tablet).
So why don’t I take you up on your offer. Thank you!
I will catch up with your changes next week, as I do want to learn these details. (I have not seen the phone issue on iPhone or Android tablet & agree initial scale is too small, was unaware of the other issues.)
🎉
Hi @gereleth!
Here is a draft of the cube grid (a step toward #83 P3 tiles). I think I've addressed everything we talked about, but if I missed anything or there's anything else you'd like changed, let me know.
I wasn't completely happy about duplicating the edge mark state for opposing tiles, but it's a really nice effect.
Moving all the transformation stuff into
TransformedPolygonTile
cleaned it up nicely. The only thing that is kind of weird is that all the method overrides have different arguments. The reason for this is mostly that the transforms need tile-relative but unflipped coordinates, so maybe this could be cleaned up.