geremih / giver

Automatically exported from code.google.com/p/giver
MIT License
0 stars 0 forks source link

Suggested feature, transfer speed cap #27

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I think giver should have a transfer speed cap.  When I transfer a file, it
uses up all the bandwidth over my network and causes my other filesharing
to stall.  I can't use giver with other applications like
transmission(torrents), because giver will use all my bandwidth.

Original issue reported on code.google.com by infamous...@gmail.com on 1 Aug 2009 at 9:34

GoogleCodeExporter commented 9 years ago
Here's some code I put together for this.

The transfer rate is throttled by specifying the rate in b/s. Example: 51200 b/s

I also added the option to the PreferencesDialog and the setting is stored in 
the
configuration file.

The attached zip is a diff of the changed files and of the new class file.

Original comment by jaredlje...@gmail.com on 5 Feb 2010 at 5:31

Attachments:

GoogleCodeExporter commented 9 years ago
Jared, if you `svn add` the new file, the output of `svn diff` will contain the 
new 
file contents, and you can simply attach a plain text diff file.

Original comment by sanforda...@gmail.com on 5 Feb 2010 at 6:29

GoogleCodeExporter commented 9 years ago
Also, these appear to be reverse patches.  I guess they were made with `diff` 
instead 
of `svn diff`, and the arguments were reversed?

Patches made with `svn diff` are a lot easier to review.

Original comment by sanforda...@gmail.com on 5 Feb 2010 at 6:31

GoogleCodeExporter commented 9 years ago
Like this?

The svn diff attached has some other changes that I made to the project for me. 
I can
try to clean it up if it's to awkward or unusable.

Original comment by jaredlje...@gmail.com on 16 Feb 2010 at 12:17

Attachments:

GoogleCodeExporter commented 9 years ago
Yup, that's better.  Will review when I get a chance.

Original comment by sanforda...@gmail.com on 16 Feb 2010 at 3:01