gergelyszabo94 / csgo-trader-extension

CSGO Trader Browser Extension to help with CS:GO item trading, marketing and much more
https://csgotrader.app
GNU General Public License v3.0
211 stars 41 forks source link

Outbid button doesn't work sometimes #436

Closed infidel04 closed 2 years ago

infidel04 commented 2 years ago

On the page https://steamcommunity.com/market/

Clicking the green outbid button sometimes just sets the price of a buy offer to be the same as the current highest bid.

The buy order price goes from red to green but it doesn't outbid it.

Happens like 10% of the time. Has been happening for like the past 6 months.

gergelyszabo94 commented 2 years ago

@infidel04 Have you noticed any pattern to which items ite happens to? Could it be that someone made the same bid between the extension checking the current highest bid and you clicking oudbid?

infidel04 commented 2 years ago

I have not noticed a pattern. No, that cant be the issue. It happens as often with very low volume Rust items.

gergelyszabo94 commented 2 years ago

Okay, how expensive are these items btw?

infidel04 commented 2 years ago

They vary a lot and I haven't noticed a pattern in price either. From 3-230 eur.

infidel04 commented 2 years ago

idk if u did anything but it seems to be fixed. could've also just been my error all this time

gergelyszabo94 commented 2 years ago

I haven't even tested it yet, no. I have not used this feature myself for a long time but I suspect I would have noticed it happening if it hapens 10% of the time. Something might have been changed since though,

infidel04 commented 2 years ago

Hey, I have noticed it happening again, it really is a thing. Happens like 10-20% of the time for me.

The "outbid" button either matches the price of the highest offer or doesn't change the price at all.

gergelyszabo94 commented 2 years ago

So I went on to investigate this now. I set 10 buy orders for csgo items of varying prices. My buy orders were never the highest so when I loaded the market page they were all red: image Then I went on to outbid each of them, which worked as designed in all cases: image I also opened each listing page after outbidding and I noticed that I was immediatelly outbid on one of the item. Reloading the market page confirmed this: image

In short I was not able to reproduce the issue. It could be something language, currency or browser specific. I am closing the issue now, feel free to reopen it if you find a way to consistently reproduce it.