gergelyszabo94 / csgo-trader-extension

CSGO Trader Browser Extension to help with CS:GO item trading, marketing and much more
https://csgotrader.app
GNU General Public License v3.0
211 stars 41 forks source link

steam API requests #462

Closed tomassator closed 1 year ago

tomassator commented 1 year ago

A few days ago, when I use the steam extension, it gives me an error indicating that too many requests were made to the server and the market is blocked for a few hours. Could you verify the number of transactions you are currently sending each time the page is updated? Captura de pantalla 2022-10-30 025016

gergelyszabo94 commented 1 year ago

@tomassator
Are we talking about the market home page? https://steamcommunity.com/market/

tomassator commented 1 year ago

@tomassator
Are we talking about the market home page? https://steamcommunity.com/market/

No, the market home page works fine. The problem is when I want to see a particular article, I get that error message. Occurs for all items.

Observation: This error started to occur with the latest version of chrome

gergelyszabo94 commented 1 year ago

@tomassator Hmm, that is actually weirder because there should not be a whole lot of excess requests to Steam because of the extension. How many listings per page do you set the extension to load? (Option -> Market -> Listings per page). Chrome update is unlikely (altough can't be rulled out). What version are of the extension/chrome are you on? The last extension update introduced a new market feature, perhaps you could try turning that off? (Option -> Market -> Show years on market graphs)

tomassator commented 1 year ago

@tomassator Hmm, that is actually weirder because there should not be a whole lot of excess requests to Steam because of the extension. How many listings per page do you set the extension to load? (Option -> Market -> Listings per page). Chrome update is unlikely (altough can't be rulled out). What version are of the extension/chrome are you on? The last extension update introduced a new market feature, perhaps you could try turning that off? (Option -> Market -> Show years on market graphs)

I put you in context. I am using the extension together with selenium to automate some purchases, two/three days ago I had to update the chromedriver because chrome was updated to version 107. Before that I had no problems with requests, in fact I was updating approximately 10 pages of different articles every 4 minutes.

With the latest version of chrome, the error just appears after about 20 page refreshes in total, so in terms of time it's 10 minutes until the error appears.

The version of chrome that I have is 107

The number of items per page that I have configured is 100, although I always had it like this

gergelyszabo94 commented 1 year ago

I see, I updated to Chrome 107, I don't see any changes that would affect this, but again it can't be ruled out. If you have listings per page set to 100 then that is 1 additional request every time a listings page is loaded. Furthermore the extension starts the ItemActivityTicker which makes additional requests every few seconds (this happens without the extension too on commodity items, it only happens with the extension installed on non-commodity items).

"Reload listings on error" this option could be giving you issues, it does not make additional requests but it does reload the page when it does not load properly. Perhaps Steam is limiting you more "softly" first with errors, but the extension keeps reloading the pages with these errors.

tomassator commented 1 year ago

I see, I updated to Chrome 107, I don't see any changes that would affect this, but again it can't be ruled out. If you have listings per page set to 100 then that is 1 additional request every time a listings page is loaded. Furthermore the extension starts the ItemActivityTicker which makes additional requests every few seconds (this happens without the extension too on commodity items, it only happens with the extension installed on non-commodity items).

"Reload listings on error" this option could be giving you issues, it does not make additional requests but it does reload the page when it does not load properly. Perhaps Steam is limiting you more "softly" first with errors, but the extension keeps reloading the pages with these errors.

After doing some more research and consulting with other people, apparently Steam put tighter restrictions on requests these days. Let's hope it's temporary. Thanks for your help

nutinshell commented 1 year ago

The issue still exists. A while ago, I disabled the plugin in Chrome because of this reason and the problem disappeared. Now, when I try to enable the plugin, the problem reappears.

gergelyszabo94 commented 1 year ago

It's not surprising if you get limited with the extension if you have it set up to make a pretty heavy market request (100 listings).

nutinshell commented 1 year ago

It's not surprising if you get limited with the extension if you have it set up to make a pretty heavy market request (100 listings).

that's pretty sad :(