gergo85 / oc-news

This is the simple news and newsletter plugin for October CMS and Winter CMS.
http://octobercms.com/plugin/indikator-news
MIT License
42 stars 29 forks source link

Plugin Improvements #80

Open nfebe opened 6 years ago

nfebe commented 6 years ago

Thank you awesome developer of this plugin! I choosed your plugin over RainLab.Blog because of the news letter ability and simplicity with which the variables are made available on the page. Also I personally prefer it's interface simple and better. However advanced users may find the plugin incomplete for the following reason

  1. post.user not available? Authors of posts should be available as a key feature
  2. Things like post.next and post.prev and a pagination for posts (The pagination code on rainlab.blog seems to work on indikator.news though) as those are traditional requirements in blog iterations
  3. It's not particularly clear on how to go about email settings like changing default messages and all.
  4. Despite the simplicity of Rainlab.Blog hundred of developers have built extension plugins for it so developers are likely to choose to save some time. For example there's a Blog Views counter for RainLab.Blog which counts page views and produces a component for popular posts this is (or was not available for Indikator.News) I however created a copy of Blog Views for indikator you can find it here : https://github.com/Fenn-CS/newspageviews works exactly the same way it would work on RainLab.Blog.
  5. Since a lot of developers are building on RainLab and not Indikator I think it has to ship with a lot of tools out of box to make it more appealing.

Available to help if need be, just like newspageviews I would be building (or copying if you want) more extensions for Indikator.News but please try to fix this basic issues and thank you for the work so far!!

gergo85 commented 6 years ago

Thank you for your useful feedback! I will fix this issues as soon as. I'm glad you're making extensions for it.

nfebe commented 6 years ago

Great. Following up :)

nfebe commented 6 years ago

First plugin on Indikator.News now available in OctoberCMS store. https://octobercms.com/plugin/fenncs-newspageviews

gergo85 commented 6 years ago

I added your plugin to the documentation.

nfebe commented 6 years ago

@gergo85 Have you added a webhook to this repository? I am asking because after the new updates I expected to see the plugin up for updates in the plugin manager but that has not been the case.

In case there's no webhook to inform the store of updates I think one should be set and if one already exist we should check why changes are not reflected.

gergo85 commented 6 years ago

@Fenn-CS How can I add webhook to this repository? I've never done this before.

nfebe commented 6 years ago

@gergo85 Please consult "Updating plugins automatically" section of this page

https://octobercms.com/help/site/authors

gergo85 commented 6 years ago

I will add some minor changes for plugin. After that I will update it.

nfebe commented 6 years ago

Ok... I also noticed when we use the WYSIWYG plugin which has support for Indikator News just the first editor (introductory) changes....

On 9 Nov 2018 10:53 am, "Szabó Gergő" notifications@github.com wrote:

I will add some minor changes for plugin. After that I will update it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gergo85/oc-news/issues/80#issuecomment-437308394, or mute the thread https://github.com/notifications/unsubscribe-auth/ANp4z8OL7UR8NDHyAG2Sj7v1TI8sfp6wks5utVCngaJpZM4XcsWW .

gergo85 commented 6 years ago

Maybe I will change the layout. But it is a WYSIWYG plugin's bug.
Also I added Author field to the form.

nfebe commented 6 years ago

Ok.... I see. But the current layout is just cool I guess.

On 14 Nov 2018 10:58 am, "Szabó Gergő" notifications@github.com wrote:

Maybe I will change the layout. But it is a WYSIWYG plugin's bug. Also I added Author field to the form.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gergo85/oc-news/issues/80#issuecomment-438605083, or mute the thread https://github.com/notifications/unsubscribe-auth/ANp4z55re8LR_VygADbfBx9hikPrLAZNks5uu-lTgaJpZM4XcsWW .

gergo85 commented 5 years ago

Finally I have changed the layout a bit because of tag list field.

nfebe commented 5 years ago

@gergo85 ok great! Thanks for the updates.

Tetraneon commented 5 years ago

Many thanks to your very useful update (author, prev and next, etc.).

Would it be abused to ask a "prevcat" and a "nextcat" to have the previous and then next post in the same category ? Best regards

nfebe commented 5 years ago

Hello Tetraneon, once you access a post object you can effectively access the category via post.category.name ...

On Fri, 7 Dec 2018, 6:41 pm Tetraneon <notifications@github.com wrote:

Many thanks to your very useful developpement of author, prev and next.

Is it abused to ask a prevcat and a nextcat to have the previous and then next post in the same category ? Best regards

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gergo85/oc-news/issues/80#issuecomment-445308947, or mute the thread https://github.com/notifications/unsubscribe-auth/ANp4z87BU8pPrzLfNzp3Ff9AiP2geMQXks5u2qg5gaJpZM4XcsWW .

Tetraneon commented 5 years ago

Hi Fenn-CS, Of course I can do that... I would use a new post.prev() fonction ("prevcat") , to navigate between posts but in the same category.

snipiba commented 5 years ago

@gergo85 perfect work bro. maybe some usefull hints for next work>

at line 83 was $top .= '<br>'; and may be $this->vars['top'] .= '<br>';

gergo85 commented 5 years ago

@snipiba Thank you for your remark!
I fixed the statistics issue and I added the seo options to my to-do list.

gergo85 commented 5 years ago

@snipiba I added SEO fields to news.

snipiba commented 4 years ago

@gergo85 ... maybe next time... something like author bio or profile, to create a linkable profile with author articles, biography, links to social media, avatar, etc. what u think?