gerich-home / it-depends

Lightweight dependency tracking library for JavaScript
http://it-depends-js.github.io/
Other
1 stars 2 forks source link

Move `coveralls` gulp task to appveyor.yml? #55

Closed VanDalkvist closed 8 years ago

VanDalkvist commented 8 years ago

During creating new Appveyor build I faced out with issue - I could not pass a build with unit-tests gulp task because it depends on coveralls task which should be configured for appveyor build previously. I am proposing move coveralls task somewhere to be executed after unit-tests are done.

gerich-home commented 8 years ago

Agree, this needs to be changed. We could:

  1. Move the logic of https://github.com/gerich-home/it-depends/blob/master/gulp/unit-tests.js#L26 to appveyor.yml for now
  2. Add one more check to https://github.com/gerich-home/it-depends/blob/master/gulp/unit-tests.js#L26 to verify we have decrypted coveralls.yml file in the repo root.

As a bigger task we could move to gulp 4 and use the approach proposed in the end of this article: http://blog.reactandbethankful.com/posts/2015/04/23/building-with-gulp-3-and-4-part-1-examples/

VanDalkvist commented 8 years ago

About gulp 4. It is not released yet, as I see. https://github.com/gulpjs/gulp/releases

gerich-home commented 8 years ago

ah, ok. Well - then just 1 or 2. Or both at once.

VanDalkvist commented 8 years ago

I can do it I think

gerich-home commented 8 years ago

Do it! :)

VanDalkvist commented 8 years ago

Closed due to #62