search

gerlichlab / looptrace

Fork (from EMBL Gitlab) of the looptrace project: https://git.embl.de/grp-ellenberg/looptrace
Apache License 2.0
2 stars 1 forks source link

Folder combination program is too sensitive to filenames with commas and spaces #289

Closed vreuter closed 8 months ago

vreuter commented 8 months ago

Noticed w/ @josephneos1010

vreuter commented 8 months ago

B/c of this change: https://github.com/gerlichlab/looptrace/commit/7222ce2febc20373063f78d584e204ea975e0ffb#diff-53a6f50a981c928f4ed8802361e2e410ac03fc44b6222c1a2ce0d7c8d6f1439a

vreuter commented 8 months ago 
scala> preFields :+ res3 ++ postFields.tail
val res4: Array[String | IndexedSeq[Char | String]] = Array(20240313, 155456, 993, "", Vector(T, i, m, e, 0, 0, 0, 4, 2, Point0012, ChannelFar Red,Red, Seq0558.nd2))

scala> preFields ++ Array(res3) ++ postFields.tail
val res5: Array[String] = Array(20240313, 155456, 993, "", Time00042, Point0012, ChannelFar Red,Red, Seq0558.nd2)
vreuter commented 8 months ago

^^ unfortunately, the compiler allows the first expression above, inferring an odd type that would be atypical to have as intended behavior in such a use context, but alas, we will wrap the value.