search

gerlichlab / looptrace

Fork (from EMBL Gitlab) of the looptrace project: https://git.embl.de/grp-ellenberg/looptrace
MIT License
2 stars 1 forks source link

Drift correction isn't used in background subtraction #77

Open vreuter opened 11 months ago

vreuter commented 11 months ago

Right now on the primary feature branch, we simplify background subtraction procedure to not use the drift correction. However, we should go back to trying to use this when other diagnostics are done and other pieces are fixed.

vreuter commented 11 months ago

Look in looptrace.Tracer.find_trace_fits

vreuter commented 11 months ago

This interacts with mask_fits, in fact appearing to be relevant solely in the case of mask_fits: True:

Upstream: https://git.embl.de/grp-ellenberg/looptrace/-/blob/master/looptrace/Tracer.py?ref_type=heads#L90-117 Us: https://github.com/gerlichlab/looptrace/blob/main/looptrace/Tracer.py#L225-L243, called here: https://github.com/gerlichlab/looptrace/blob/main/looptrace/Tracer.py#L101-L107