germainelee02 / pe

0 stars 0 forks source link

Able to have a person with a different name, but with the same email, same github profile, and same name #3

Open germainelee02 opened 1 year ago

germainelee02 commented 1 year ago

I believe that the duplication checking should not be used with respect to one's name, but with respect to one's email and github and phone instead.

Screenshot 2023-04-14 at 2.26.01 PM.png

nus-se-script commented 1 year ago

Team's Response

This bug report is rejected, as different contacts may share the same contact details as they may want to be contacted through the same avenue, or use the same accounts. Furthermore, this is common practice in many contact management software, and as such, is the convention for such applications.

For example, different contacts may wish to be contacted through the same house phone, or prefer to be reached through the same email, or use a single github profile for collaborative work.

Also, we would like to request that the tester clarify what he means by "Able to have a person with a different name ... and same name", as there is a conflict in the statement.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: > Also, we would like to request that the tester clarify what he means by "Able to have a person with a different name ... and same name", as there is a conflict in the statement.

I did not say that. I am saying that duplicate checking should be with regards to the github profile or email address, not one's name.

different contacts may wish to be contacted through the same house phone, or prefer to be reached through the same email, or use a single github profile for collaborative work.

It is unlikely that you would have a contact 'Bernice', 'Calvin', and 'Sarah' with the same organisation phone number. If so, they would probably be grouped together as 'Organisation 1' with the same phone number.

use a single github profile for collaborative work.

I am pretty sure people don't use the same github profile for work. Everyone can collaborate on a github repo, but they use their own separate accounts. This argument is really astonishing.

All in all, there is a feature flaw in which your duplicate checking should be checking on items that more uniquely represent a person, such as one's phone number or emails, instead of one's names.

Actually, upon further inspection, this should actually be a severity.Medium.