germaintanon / flot

Automatically exported from code.google.com/p/flot
MIT License
0 stars 0 forks source link

Test canvas text on Konqueror #546

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Used in measureTickLabels, without checking for availability.

Original issue reported on code.google.com by l...@dashjr.org on 5 Jun 2011 at 12:42

GoogleCodeExporter commented 8 years ago
This issue also exists on any Opera version older than 10.60 (i.e. anything 
using Presto older than 2.6). http://www.opera.com/docs/specs/presto26/canvas/ 
shows the first version of presto where measureText is supported; older 
versions either don't show it or note it as unsupported (see 
http://www.opera.com/docs/specs/opera95/canvas/ for Presto 2.1).

The error which opera throws is: Type mismatch (usually non-object value 
supplied where object required)

See also http://tickets.musicbrainz.org/browse/MBS-2689 which is the downstream 
issue . That one shows line 33, since that's what it ends up in our minified 
version; however, the actual issue is line 873 in measureTickLabels:

   m = ctx.measureText(line.text);

The example pages at http://people.iola.dk/olau/flot/examples/ all work because 
of an older version of flot; that fallback method should probably be used when 
ctx.measureText is undefined.

Original comment by mcewen....@gmail.com on 10 Jun 2011 at 8:11

GoogleCodeExporter commented 8 years ago
If you check the new NEWS.txt, there's some info. It was also discussed on the 
mailing list.

I'm not sure we're going to stay with canvas text for default, though, it has 
some upsides, but fewer than I hoped, and some definite downsides.

Original comment by olau%iol...@gtempaccount.com on 23 Jun 2011 at 7:15

GoogleCodeExporter commented 8 years ago
I found nothing relevant in NEWS.txt.

Original comment by l...@dashjr.org on 23 Jun 2011 at 7:25

GoogleCodeExporter commented 8 years ago
Strange, it's one of the first things mentioned:

"Axis labels are now drawn with canvas text with some parsing to
support newlines. This solves various issues but also means that they
no longer support HTML markup, can be accessed as DOM elements or
styled directly with CSS. Some older browsers lack this function of
the canvas API (this doesn't affect IE); if this is a problem, either
continue using an older version of Flot or try an emulation helper
such as canvas-text or Flashcanvas."

If you search on the mailing list for canvas text, my announcement and 
resulting discussions should turn up. But as a said, we might still move the 
canvas text dependency to a plugin.

Original comment by olau%iol...@gtempaccount.com on 23 Jun 2011 at 7:33

GoogleCodeExporter commented 8 years ago
First paragraph:

Axis labels are now drawn with canvas text with some parsing to
support newlines. This solves various issues but also means that they
no longer support HTML markup, can be accessed as DOM elements or
styled directly with CSS. Some older browsers lack this function of
the canvas API (this doesn't affect IE); if this is a problem, either
continue using an older version of Flot or try an emulation helper
such as canvas-text or Flashcanvas.

http://code.google.com/p/canvas-text/ is the canvas-text that's referred to, I 
think.

Original comment by mcewen....@gmail.com on 23 Jun 2011 at 7:33

GoogleCodeExporter commented 8 years ago
Heh, beat me to it.

Original comment by mcewen....@gmail.com on 23 Jun 2011 at 7:33

GoogleCodeExporter commented 8 years ago
Keeping this open as a reminder to test the new canvas text across a range of 
browsers if/when it's officially decided to include it in a release.

Original comment by dnsch...@gmail.com on 8 May 2012 at 8:30