State in querystring instead of cookie (retraining branch)

germanattanasio / visual-recognition-nodejs

DEPRECATED: this repo is no longer actively maintained

Apache License 2.0

361 stars 351 forks source link

State in querystring instead of cookie (retraining branch) #209

Closed nfriedly closed 8 years ago

nfriedly commented 8 years ago

This is a dupe of #208 targeted at retraining branch.

Not ready to merge just yet

Just sending a PR to let other folks see which way I'm heading.

This is a quick-and-dirty implementation that seems to more or less work. The querystring is a bit long and ugly, but it gets the job done for now.

Tested on prebuilt bundles, but not yet on custom ones, nor with retraining.

nfriedly commented 8 years ago

I added some polish, including an error message if you visit a url for an expired classifier. (Check out

http://localhost:3000/train?classifier_id=DogBreeds_1241485912&name=Dog%20Breeds&kind=dogs&expires=Mon%20Aug%2015%202016%2018%3A17%3A48%20GMT-0500%20(CDT)

to see it in action.)

One thing I just thought of is that we should also show that error after an hour (or just refresh the page, which will trigger it.)