search

germanbrew / terraform-provider-hetznerdns

Terraform provider for Hetzner DNS
https://registry.terraform.io/providers/germanbrew/hetznerdns/latest
Mozilla Public License 2.0
16 stars 0 forks source link

Zone resource does not allow dot separated TLD's (such as `co.za`) #117

Closed J4NS-R closed 1 day ago

J4NS-R commented 1 day ago

https://github.com/germanbrew/terraform-provider-hetznerdns/blob/5b7a37c4663b73dbec292eb8301e2ec4e5b0fbbf/internal/provider/zone_resource.go#L73

The regex for the name attribute of the zone resource only allows one dot character. There are top-level domains that contain two dot characters, such as *.co.za, *.net.za (my use cases), but also .co.nz, and many others. General members of the public have no control over the co.za, co.nz etc nameservers, and so there is no workaround here.

Please update the regex to allow two dot characters, or otherwise loosen the restrictions. Note that two-dot TLDs work fine with the upstream (timohirt/hetznerdns).

Thank you for your consideration. Let me know if I should make a PR.

J4NS-R commented 1 day ago

@kimdre @jkroepke - bumping for visibility.

kimdre commented 1 day ago

Should be fixed with the new version v3.2.1. :)

J4NS-R commented 1 day ago

Tested it now and it works!

@kimdre You are an absolute legend.