Replaces slice_deque with slice_ring_buffer (maintained fork)

germangb / minimp3-rs

minimp3 rust bindings + wrapper

MIT License

66 stars 22 forks source link

Replaces slice_deque with slice_ring_buffer (maintained fork) #38

Closed LiquidityC closed 2 months ago

LiquidityC commented 3 years ago

Fixes: #29

germangb commented 2 years ago

Thanks for the PR. I'm a bit busy lately but soon I will have free time to catch up

LiquidityC commented 2 years ago

No worries. In your own time

ArthurKValladares commented 2 years ago

Thanks so much for the PR. This touches some code that causes apps using this crate to fail App Store Certification, which we can fix by exposing a slice_ring_buffer crate feature like I did here: https://github.com/LiquidityC/minimp3-rs/pull/1

I now realize that I probably should have opened this as its own PR, instead of forking from this one, which I can do if that's preferred.

ImUrX commented 2 years ago

@germangb any news?

est31 commented 1 year ago

@germangb I've received https://github.com/RustAudio/rodio/pull/504 and will merge it, but would love if this PR could be merged (or maintenance be given to other people) so that I can switch back to the proper minimp3.