germanhmartinez / font-manager

Automatically exported from code.google.com/p/font-manager
GNU General Public License v3.0
1 stars 0 forks source link

rm -rfv or rm -fv is not portable #56

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
-v for rm command is not portable, it does not exist on OpenBSD for example.

Index: Makefile.in
===================================================================
--- Makefile.in (revision 261)
+++ Makefile.in (working copy)
@@ -187,8 +187,8 @@
 INSTALL_BIN = $(INSTALL) -m 755
 INSTALL_FILE = $(INSTALL) -m 644
 INSTALL_DIR = $(INSTALL_BIN) -d
-REMOVE = @rm -fv
-RECURSIVE_REMOVE = @rm -rfv
+REMOVE = @rm -f
+RECURSIVE_REMOVE = @rm -rf
 @BYTECODE_FALSE@Py_Compile = 
 @BYTECODE_TRUE@Py_Compile = @$(PYTHON) -m compileall $(SRC_DIR)
 @BYTECODE_FALSE@Py_Optimize = 
Index: Makefile.am
===================================================================
--- Makefile.am (revision 261)
+++ Makefile.am (working copy)
@@ -29,8 +29,8 @@
 INSTALL_BIN = $(INSTALL) -m 755
 INSTALL_FILE = $(INSTALL) -m 644
 INSTALL_DIR = $(INSTALL_BIN) -d
-REMOVE = @rm -fv
-RECURSIVE_REMOVE = @rm -rfv
+REMOVE = @rm -f
+RECURSIVE_REMOVE = @rm -rf

 if !BYTECODE
   Py_Compile = 

Original issue reported on code.google.com by ji...@devio.us on 24 Mar 2011 at 11:07

GoogleCodeExporter commented 9 years ago
cp -v does not also exist on OpenBSD

updated patch bellow:

Index: Makefile.in
===================================================================
--- Makefile.in (revision 261)
+++ Makefile.in (working copy)
@@ -187,8 +187,8 @@
 INSTALL_BIN = $(INSTALL) -m 755
 INSTALL_FILE = $(INSTALL) -m 644
 INSTALL_DIR = $(INSTALL_BIN) -d
-REMOVE = @rm -fv
-RECURSIVE_REMOVE = @rm -rfv
+REMOVE = @rm -f
+RECURSIVE_REMOVE = @rm -rf
 @BYTECODE_FALSE@Py_Compile = 
 @BYTECODE_TRUE@Py_Compile = @$(PYTHON) -m compileall $(SRC_DIR)
 @BYTECODE_FALSE@Py_Optimize = 
@@ -591,7 +591,7 @@
        $(INSTALL_FILE)  $(SRC_UTILS_DIR)/$(PyFiles)   $(INST_DATA_DIR)/utils/
        @$(FIND) help -type f -exec chmod 644 '{}' \;
        @$(FIND) help -type d -exec chmod 755 '{}' \;
-       cp -Rv help $(INST_DATA_DIR)/
+       cp -R help $(INST_DATA_DIR)/

 uninstall:
        $(REMOVE) $(INST_BIN_DIR)/$(PACKAGE_NAME)
Index: Makefile.am
===================================================================
--- Makefile.am (revision 261)
+++ Makefile.am (working copy)
@@ -29,8 +29,8 @@
 INSTALL_BIN = $(INSTALL) -m 755
 INSTALL_FILE = $(INSTALL) -m 644
 INSTALL_DIR = $(INSTALL_BIN) -d
-REMOVE = @rm -fv
-RECURSIVE_REMOVE = @rm -rfv
+REMOVE = @rm -f
+RECURSIVE_REMOVE = @rm -rf

 if !BYTECODE
   Py_Compile = 
@@ -149,7 +149,7 @@
        $(INSTALL_FILE)  $(SRC_UTILS_DIR)/$(PyFiles)   $(INST_DATA_DIR)/utils/
        @$(FIND) help -type f -exec chmod 644 '{}' \;
        @$(FIND) help -type d -exec chmod 755 '{}' \;
-       cp -Rv help $(INST_DATA_DIR)/
+       cp -R help $(INST_DATA_DIR)/

 uninstall:
        $(REMOVE) $(INST_BIN_DIR)/$(PACKAGE_NAME)

Original comment by ji...@devio.us on 25 Mar 2011 at 12:07

GoogleCodeExporter commented 9 years ago
Pretty lame on the part of OpenBSD... How hard can it be to just accept the 
option and do nothing with it? Can't be that hard.

I appreciate your interest and of course patches are always welcome, I'll apply 
it to SVN when I get a chance. Thank you.

Just so you know though, Font Manager is being slowly re-written once again and 
may not even resemble the current version once it's done, so at this point it's 
unlikely there will be a release anytime soon. If you're up for testing, let me 
know, but keep in mind that it's at a very early stage.

Original comment by JerryCasiano on 25 Mar 2011 at 4:43

GoogleCodeExporter commented 9 years ago
The version of Font Manager that this bug applies to is deprecated.

Please test with the latest revision.

Original comment by JerryCasiano on 27 Apr 2014 at 8:22