germanysbestkeptsecret / Wookmark-jQuery

A jQuery plugin to create a dynamic, multi-column layout.
MIT License
2.63k stars 759 forks source link

Add items to the grid without recalculating heights? #160

Closed ianmurrays closed 10 years ago

ianmurrays commented 10 years ago

Thanks for this great plugin! I'm currently using it with Angular and I'm having serious performance issues while scrolling down and adding new items. The problem is that whenever I add new items I'm reloading Wookmark just as you do in the endless scroll example, but this requires Wookmark to recalculate all of the heights of each card, effectively bringing FPS down to less than 10.

Is there anyway to "add" new items, telling wookmark not to recalculate the heights of all the tiles but just the new ones?

Thanks!

Sebobo commented 10 years ago

Hi,

how often do you recalculate? For each item or in batches?

It shouldn't be that slow though, except you have an enourmous amount of tiles. Of course it would be possible to enhance the refreshWookmark method to have an option only to check items not yet positioned. Have to think about this.

ianmurrays commented 10 years ago

I was thinking about the latter. I recalculate in batches, but according to chrome's dev tools the calculation of outerHeight is quite expensive. — Ian Murray S. Sent via mobile, please excuse brevity and grammar.

On Wed, May 21, 2014 at 3:47 PM, Sebastian Helzle notifications@github.com wrote:

Hi, how often do you recalculate? For each item or in batches?

It shouldn't be that slow though, except you have an enourmous amount of tiles. Of course it would be possible to enhance the refreshWookmark method to have an option only to check items not yet positioned. Have to think about this.

Reply to this email directly or view it on GitHub: https://github.com/GBKS/Wookmark-jQuery/issues/160#issuecomment-43805048