search

germanysbestkeptsecret / Wookmark-jQuery

A jQuery plugin to create a dynamic, multi-column layout.
MIT License
2.63k stars 759 forks source link

Fix in jquery dependency #163

Closed guiwoda closed 10 years ago

guiwoda commented 10 years ago

The caps in the "Q" breaks compatibility with other libraries. Should be all lowercase.

simonsmith commented 10 years ago

Any chance you can push a new tag with this fix? It's a real problem when you have jquery installed as it overwrites it. I can install from master but would prefer to use a tag for stability.

guiwoda commented 10 years ago

@simonsmith What do you mean with "it overwrites it"? Bower will parse your dependencies and get the "best" jquery for you. This change only improves compatibility with other libraries that depend on jquery, as the official jquery dependency is all lowercased.

simonsmith commented 10 years ago

If I have jquery installed via Bower already and then I try to install Wookmark 1.4.7 then my jquery folder gets replaced with jQuery which is a totally different thing.

If you update your bower.json but don't push a tag then the changes can't be taken advantage of unless I were to install #master but then I receive the entire repo and a potentially unstable version.

guiwoda commented 10 years ago

@simonsmith Oh, got that backwards, then! Yes, please, let's tag this!

@Sebobo

Sebobo commented 10 years ago

Hey, I'll try to make a new release today or tomorrow.

Sebobo commented 10 years ago

Ok done ;)

simonsmith commented 10 years ago

Awesome! Thanks guys