search

germanysbestkeptsecret / Wookmark-jQuery

A jQuery plugin to create a dynamic, multi-column layout.
MIT License
2.64k stars 759 forks source link

Are window and document realy needed? #224

Closed teawithfruit closed 7 years ago

teawithfruit commented 7 years ago

Hey, Are window and document in the factory code realy needed? If I remove them, the lib still works and my webpack build do not throw error anymore because of the none found modules "window" and "document".

Thx

Sebobo commented 7 years ago

I guess it could be removed. I added it at the time because of some "best practice" regarding testing with phantomjs and so on. But maybe things have changed again.

teawithfruit commented 7 years ago

Thanks for your instant answer. :)