search

germsvel / phoenix_test

MIT License
144 stars 20 forks source link

Allow non-string data types as inputs to fields. #100

Closed soundmonster closed 1 month ago

soundmonster commented 1 month ago

Fixes #98

soundmonster commented 1 month ago

PR number 💯 🥳

soundmonster commented 1 month ago

I considered that but it felt safer to change one place instead of two. But I can see how keeping this kind of casting logic at the perimeter makes sense, keeping the internal data structure string-only. I'll try that, thank you!

soundmonster commented 1 month ago

@germsvel the conversion to strings is happening in the fill_in function now, in the two adapters, please have another look.