search

germsvel / phoenix_test

MIT License
144 stars 20 forks source link

Fix #57: Submit pre-rendered data in static forms #58

Closed ftes closed 4 months ago

germsvel commented 5 months ago

Thanks for opening this PR with the failing tests @ftes! That's super helpful. Would you be interested in getting this through the finish line? I think we just need to update this to include all the potential "default" fields: https://github.com/germsvel/phoenix_test/blob/b5932b603fc43e66cc7774d3a59ec2ee725f5723/lib/phoenix_test/form.ex#L85-L89

If not, I'll make the changes based on this PR.

ftes commented 5 months ago

Absolutely, taking a look straight away.

germsvel commented 5 months ago

Thanks! The Form module isn't unit tested very thoroughly (you caught me sort of in the middle of some larger refactorings that created that module). But it should mostly be tested through live_test and static_test. Let me know if you have questions, or if I can help somehow.

ftes commented 4 months ago

@germsvel All done from my side. Wdyt?