search

germsvel / phoenix_test

PhoenixTest provides a unified way of writing feature tests -- regardless of whether you're testing LiveView pages or static (non-LiveView) pages.
https://hex.pm/packages/phoenix_test
MIT License
170 stars 22 forks source link

Handle multiple select in forms #71

Closed sasikumar87 closed 5 months ago

sasikumar87 commented 5 months ago

Closes https://github.com/germsvel/phoenix_test/issues/70

sasikumar87 commented 5 months ago

@germsvel There are some test cases still failing. See if you have any feedbacks. I'll give another attempt tomorrow.

germsvel commented 5 months ago

@sasikumar87 thanks for opening this PR! 🎉 I've given it a quick glance, but I need to give it a better look. I don't have time right now, but I'll do it as soon as I can.

Aside from the TODO to raise an error, do you see it as done? Or are there any other open questions that I might be able to help with?

sasikumar87 commented 5 months ago

@germsvel Thanks. I have rebased for recent changes. With this, apart from TODO, I see it done.

sasikumar87 commented 5 months ago

@germsvel I have updated. can you review again?