search

germsvel / phoenix_test

MIT License
144 stars 20 forks source link

Add regular Endpoint and esbuild #91

Closed ftes closed 1 month ago

ftes commented 2 months ago

Extracted from #74

Goal

Prepare for browser-based tests: Extend the test set up to allow running a Phoenix server with LiveView (javascript).

germsvel commented 2 months ago

@ftes I think this might be better included as part of the Wallaby PR. Some of the changes (like setting the server: true in config only make sense in that context.

I know you broke this apart so it'd be easier to review (and thank you!), but since this one is more tied to Wallaby, I think it's fine to introduce with it. I really do appreciate the other refactorings though. Those were good stuff! 👍

germsvel commented 1 month ago

@ftes now that I've given this PR a second look, I think it'd be okay merging on its own. I like the work here, and though some stuff is closely related to trying to introduce Wallaby, I think it can go on its own.

Do you mind trying to resolve merge conflicts and then we can get this in?

Thanks again for all the work! 💯

ftes commented 1 month ago

Sure, I'll resolve the merge conflicts shortly!

germsvel commented 1 month ago

Thanks @ftes! 🎉