germsvel / phoenix_test

PhoenixTest provides a unified way of writing feature tests -- regardless of whether you're testing LiveView pages or static (non-LiveView) pages.
https://hex.pm/packages/phoenix_test
MIT License
181 stars 23 forks source link

Query associated element with `[id='<id>']` #99

Closed germsvel closed 4 months ago

germsvel commented 4 months ago

Resolves #97

What changed?

It turns out that Chrome and Firefox don't accept #text? as a valid selector. But having a ? in an element's id seems to be valid HTML.

Thank to https://github.com/philss/floki/issues/583 for the info.

To support that, we update our Query.find_by_label function to query by [id='<id>'] instead of using #<id>.