search

gernest / utron

A lightweight MVC framework for Go(Golang)
MIT License
2.22k stars 149 forks source link

Secure config #86

Closed nicola-spb closed 7 years ago

nicola-spb commented 7 years ago

In context.go you send config to view (by default). Users can save passwords and tokens in config file. I think it`s not secure. If user will want to have config in view then he put it himself.

if c.Cfg != nil {
    c.Data["Config"] = c.Cfg // add configuration to the view data context
}

What do you think?

gernest commented 7 years ago

@nicola-spb I think you are right. That is not necessary, the user should be responsible for adding data to be rendered by the templates.

OFFTOPIC: Do you mind if I add you to be a maintainer?

We will still use PR based workflow, and ensure that every PR is reviewed before merging.

nicola-spb commented 7 years ago

ok.

gernest commented 7 years ago

@nicola-spb nice, just added you. you should receive an invite any moment. Looking forward to making utron awesome with you

nicola-spb commented 7 years ago

Ok :-) will try.

nicola-spb commented 7 years ago

fixed.

gernest commented 7 years ago

@nicola-spb where?

gernest commented 7 years ago

@nicola-spb I'm sorry, but I don't think it is a good idea to make changes directly to the master branch without someone to review it.

I suggest we use a PR based approach to run this project.

These are minor changes so I'm okay with this. But please next time Open a PR, wait until at least one maintainer reviews it( It should not be the one submitting the PR) then when he/she approves you can merge to master.

Thanks.

nicola-spb commented 7 years ago

Yes. Sorry. I sent mail for you to @live.com

gernest commented 7 years ago

@nicola-spb no problem. I just saw the email a few mins ago.

We are on a good start.