geronimo-iia / winstone

Winstone is a servlet container that was written out of a desire to provide servlet functionality without the bloat that full J2EE compliance introduces.
GNU Lesser General Public License v2.1
22 stars 3 forks source link

winstone sort the filter-mapping #18

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In source file: `WebAppConfiguration.java`

Has these code: 
{{{
                if (filterPatternsRequest.length > 0) {
                        Arrays.sort(filterPatternsRequest, filterPatternsRequest[0]);
                }
                if (filterPatternsForward.length > 0) {
                        Arrays.sort(filterPatternsForward, filterPatternsForward[0]);
                }
                if (filterPatternsInclude.length > 0) {
                        Arrays.sort(filterPatternsInclude, filterPatternsInclude[0]);
                }
                if (filterPatternsError.length > 0) {
                        Arrays.sort(filterPatternsError, filterPatternsError[0]);
                }
}}}

But in file `web-app_2_5.xsd`:
Section `<xsd:complexType name="filter-mappingType">` has these words:
{{{
The order in
which filters are invoked is the order in which
filter-mapping declarations that match a request URI for a
servlet appear in the list of filter-mapping elements.
}}}

So I think winstone should not sort filter-mapping,for this reason I maintain a 
branch version of winstone, my solution is remove these sort codes.

Original issue reported on code.google.com by jht5...@gmail.com on 8 Oct 2013 at 9:51

GoogleCodeExporter commented 9 years ago
Your right
I will remove sort call

Original comment by jguibert@gmail.com on 8 Oct 2013 at 9:53

GoogleCodeExporter commented 9 years ago
Will be on 1.0.6

Original comment by jguibert@gmail.com on 18 Oct 2013 at 10:16