geronimp / graftM

GraftM - Rapid community profiles from metagenomes
http://geronimp.github.io/graftM/
GNU General Public License v3.0
44 stars 16 forks source link

create: test package works after creation #195

Closed wwood closed 8 years ago

wwood commented 8 years ago

I got sick of create going through but then later getting nasty surprises..

I'd prefer to do something along the lines of

Graft().graft(...)

But unfortunately Run is tightly coupled to argparse (args is an instance variable). If we make a new Graft class then we might need to also define a Graft.DEFAULT_PARAMETERS so that defaults can be specified in bin/graftM and in the method definition of Graft.graft without repetition (repetition might mean they become out of sync, which would be bad). ..future work.

geronimp commented 8 years ago

ok, feel free to merge... Maybe raise this as an issue so its not forgotten?