search

geronimp / graftM

GraftM - Rapid community profiles from metagenomes
http://geronimp.github.io/graftM/
GNU General Public License v3.0
44 stars 16 forks source link

Geronimp investigating pplacer issue rereplicate jplace files #201

Closed geronimp closed 8 years ago

geronimp commented 8 years ago

Passes all tests except slash error. This addresses the issue pointed out in the unmerged branch https://github.com/geronimp/graftM/pull/165 where the output placement files are not filled out with replicates (i.e. only de-replicated sequences are in the placement files).

I've fixed this issue, added a test and also removed the file aliases appended to the end of each sequence name in the jplace files. See commit comments below for specifics of the changes.

Joel

geronimp commented 8 years ago

latest wwood comments commit addressing some comments in the https://github.com/geronimp/graftM/pull/189 pull request

wwood commented 8 years ago

ok, good to go after the minor changes. Come see me about #171