search

geronimp / graftM

GraftM - Rapid community profiles from metagenomes
http://geronimp.github.io/graftM/
GNU General Public License v3.0
44 stars 16 forks source link

Add graft --decoy_database. #223

Closed wwood closed 8 years ago

geronimp commented 8 years ago

Just a thought, should sequences that were filtered by the decoy pipeline be retained somehow so that they can be added to the decoy database? It could help to develop a database of decoys as time goes on... Another option is to include decoys in the actual gpkgs, meaning you can "teach" the gpkg by adding them to the internal database. Would that be much effort to implement?

geronimp commented 8 years ago

Other than a few comments I've got no problems with this branch as it stands rn

Thanks for the good work

wwood commented 8 years ago

Interesting idea about teaching, but not so easy to implement jsut now so I'm gonna leave it. Thanks for the review.

geronimp commented 8 years ago

Thanks, didn't see your comments there - sorry for not getting to them

wwood commented 8 years ago

All good, I wasn't expecting you to actually. I just wanted to do some further testing before pushing to master.