geronimp / graftM

GraftM - Rapid community profiles from metagenomes
http://geronimp.github.io/graftM/
GNU General Public License v3.0
44 stars 16 forks source link

Remove seqmagick #245

Closed wwood closed 6 years ago

wwood commented 6 years ago

Since seqmagick has become python-3, thought we should remove it. Easy enough since it's a thin wrapper around Bio::SeqIO. Also should make graftm slightly faster as fewer subprocess python instances need to be started.

Apologies for the whitespace noise. I'm reasonably confident here as all the changes are quite local within functions, and the tests all pass.

geronimp commented 6 years ago

Looks good, although the stdout is lost in of some parts (used to be caught by extern and reported via logging.debug).

I think it should be fine though. Feel free to merge if you're happy, thanks Ben