search

gerow / sbserv

A tiny file server for serving media
BSD 2-Clause "Simplified" License
9 stars 1 forks source link

Downloading files as attachments #18

Closed seansaleh closed 8 years ago

seansaleh commented 8 years ago

To fix bug #12

seansaleh commented 8 years ago

Rereading the bug this won't fix it Rather this will fix a separate issue: on mobile browsers (or at least mobile chrome on Android) .epub gets downloaded as .zip

gerow commented 8 years ago

Will this still allow, for example, playing audio in the browser without forcing it to be downloaded first? I'm just not certain what the semantics are with an "attachment".

seansaleh commented 8 years ago

Hmmmm, this is true, I did not think of that use case. This would either require more special casing based on the file type or giving up :/ (It would mean a .mp3 or .txt would always download) On Dec 22, 2015 3:55 PM, "Mike Gerow" notifications@github.com wrote:

Will this still allow, for example, playing audio in the browser without forcing it to be downloaded first? I'm just not certain what the semantics are with an "attachment".

— Reply to this email directly or view it on GitHub https://github.com/gerow/sbserv/pull/18#issuecomment-166756397.

seansaleh commented 8 years ago

Abandoning