search

gerryhjs / gerry-themes

This repo is mainly used as issue tracker for plugins Gerry Themes and Gerry Themes Pro, also serves as archive for Gerry Themes v2022.1.x.
https://plugins.jetbrains.com/plugin/18922-gerry-themes
Apache License 2.0
20 stars 2 forks source link

Coloring odd inside of f-string query #26

Closed jeff-ws closed 9 months ago

jeff-ws commented 9 months ago

Hello-

I like your color styles and have been trying a couple of them out in PyCharm. One oddity I noticed with the coloring that does not occur in the native PyCharm modes is in the coloring of curly braces around items in f-strings near recognized table names that PyCharm highlights. Note the differently colored brackets around limit below. The normal f-string below looks fine.

Aside: Yes, I know using f-strings in queries isn't best practice for db safety, but these are all internal strings, etc.

Thanks and keep up the good work on eye-pleasing dark formats.

Screenshot 2024-01-21 at 2 23 28 PM
gerryhjs commented 9 months ago

Hi, it is likely an issue with IDE, I switch themes to default dark and issue is still exsist. So I raised an issue in youtrack for you. https://youtrack.jetbrains.com/issue/IDEA-343665/Pycharm-display-wrong-braces-colors JZ$ZISJD1(F$HF4A2)%MB O

jeff-ws commented 9 months ago

All right. Thanks. I had checked the “normal” dark mode, but the 2 colors (w/ my settings) were so similar, that I didn’t notice it. Your color scale has a bit more contrast between them. Sorry for the false accusation. ;)

On Jan 22, 2024, at 3:21 AM, gerryhjs @.***> wrote:

Hi, it is likely an issue with IDE, I switch themes to default dark and issue is still exsist. So I raised an issue in youtrack for you. https://youtrack.jetbrains.com/issue/IDEA-343665/Pycharm-display-wrong-braces-colors JZ.ZISJD1.F.HF4A2.MB.O.png (view on web) https://github.com/gerryhjs/gerry-themes/assets/45413498/6f80aa65-74b6-453c-80a3-3284f76fc7ba — Reply to this email directly, view it on GitHub https://github.com/gerryhjs/gerry-themes/issues/26#issuecomment-1903796332, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCEAVPKHXAQPTAPNT3QTECDYPZDUPAVCNFSM6AAAAABCEJRXO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBTG44TMMZTGI. You are receiving this because you authored the thread.