search

gerrymanoim / exchange_calendars

Calendars for various securities exchanges.
Apache License 2.0
396 stars 129 forks source link

BUG: Fix timezone names #393

Closed jenskeiner closed 3 weeks ago

jenskeiner commented 3 weeks ago

Hi all,

I noticed that some calendars use an incorrect or dubious timezone info. Specifically, XETR and XFRA use ZoneInfo('CET') and XNZE uses ZoneInfo('NZ').

Re XETR and XFRA, I think it's incorrect to use CET since this is a standard time, i.e. a fixed offset (+01:00) to UTC. But since Germany observes summer time (CEST = +02:00), the correct timezone to use would be ZoneInfo('Europe/Berlin').

For XNZE, I'm not even sure what the definition of ZoneInfo('NZ') is, butZoneInfo('Pacific/Auckland')` seems to be the correct time zone to use.

jenskeiner commented 3 weeks ago

Not sure what the problem with the Pull Request Labeler action/check is.

gerrymanoim commented 3 weeks ago

Please ignore the labeler for now, just needs to be updated.